Skip to content

Run Rust CI only if rust directory is modified #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
albertlockett merged 9 commits into from
Dec 8, 2025
Merged

Run Rust CI only if rust directory is modified #1529

albertlockett merged 9 commits into from
Dec 8, 2025

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented Dec 4, 2025

Avoid running CI checks unnecessarily. Need to validate if this causes any issue with "required check". Hopefully not, as this is a pattern used in other OTel repos too.

Later to be expanded to Go also.

@cijothomas cijothomas requested a review from a team as a code owner December 4, 2025 22:46
@github-actions github-actions bot added the ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores label Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.52%. Comparing base (99113cf) to head (ae01217).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
- Coverage   83.55%   83.52%   -0.04%     
==========================================
  Files         428      428              
  Lines      119720   119720              
==========================================
- Hits       100038    99991      -47     
- Misses      19148    19195      +47     
  Partials      534      534
Components Coverage Δ
otap-dataflow 84.68% <ø> (-0.07%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.30% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drewrelmas
Copy link
Contributor

drewrelmas commented Dec 5, 2025

Unfortunately, my intuition is that this will break due to required checks. Do you have an example from other opentelemetry repos showing that is not the case?

@cijothomas
Copy link
Member Author

cijothomas commented Dec 5, 2025

Unfortunately, my intuition is that this will break due to required checks. Do you have an example from other opentelemetry repos showing that is not the case?

It should not break. open-telemetry/opentelemetry-dotnet#5023 is when we tried this in .NET by @CodeBlanch !

@jmacd
Copy link
Contributor

jmacd commented Dec 5, 2025

(We'll see if it breaks!)

@jmacd jmacd added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2025
@jmacd jmacd enabled auto-merge December 5, 2025 19:22
@jmacd jmacd added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2025
@jmacd jmacd added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2025
@jmacd jmacd added this pull request to the merge queue Dec 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 6, 2025
@albertlockett albertlockett added this pull request to the merge queue Dec 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 8, 2025
@drewrelmas
Copy link
Contributor

drewrelmas commented Dec 8, 2025

@cijothomas The Rust-CI workflow fails in merge queue on the new check-changes job: https://github.com/open-telemetry/otel-arrow/actions/runs/20029073546/job/57433396112

@cijothomas
Copy link
Member Author

cijothomas commented Dec 8, 2025

@cijothomas The Rust-CI workflow fails in merge queue on the new check-changes job: https://github.com/open-telemetry/otel-arrow/actions/runs/20029073546/job/57433396112

Pushed a fix. If this does not work, then I'll come back to this a bit later. Please add this to merge-queue once more.

@albertlockett albertlockett added this pull request to the merge queue Dec 8, 2025
Merged via the queue into open-telemetry:main with commit 314cd28 Dec 8, 2025
34 checks passed
@cijothomas cijothomas deleted the cijothomas/selective-ci branch December 8, 2025 18:13
@cijothomas cijothomas mentioned this pull request Dec 8, 2025
Merged
CodeBlanch
CodeBlanch reviewed Dec 8, 2025
View reviewed changes
.github/workflows/rust-ci.yml
check-changes:
runs-on: ubuntu-latest
outputs:
rust: ${{ steps.filter.outputs.rust }}
Copy link
Member

@CodeBlanch CodeBlanch Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cijothomas It has been a while since I worked on this in .NET repo but the issue may be here. What the check-changes outputs gives you is an array of strings IIRC.

Try changing this line to like...

rust: ${{ contains(steps.filter.outputs.changes, 'rust') }}

cijothomas added a commit to cijothomas/otel-arrow that referenced this pull request Dec 8, 2025
@cijothomas
Revert "Run Rust CI only if rust directory is modified (open-telemetr…
982e107 
…y#1529)"

This reverts commit 314cd28.
github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2025
@cijothomas
Revert "Run Rust CI only if rust directory is modified (#1529)" (#1548)
a36dae5 
This reverts commit 314cd28.

More changes are required before this can be run without issues.
Reverting now to unblock the repo's CI checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmacd jmacd jmacd approved these changes

@albertlockett albertlockett albertlockett approved these changes

+1 more reviewer

@CodeBlanch CodeBlanch CodeBlanch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores

Projects

OTel-Arrow
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cijothomas @drewrelmas @jmacd @albertlockett @CodeBlanch